This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Redo simplify invert colors. #46416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
| #include "flutter/fml/trace_event.h" | ||
| #include "impeller/aiks/color_filter.h" | ||
| #include "impeller/core/formats.h" | ||
| #include "impeller/display_list/dl_image_impeller.h" |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 29, 2023
flutter/engine@48973d7...d203e34 2023-09-29 dkwingsmt@users.noreply.github.com Multi-view Rasterizer (flutter/engine#45512) 2023-09-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 955a3a964621 to 0931bb8a43c8 (1 revision) (flutter/engine#46423) 2023-09-29 jonahwilliams@google.com [Impeller] Redo simplify invert colors. (flutter/engine#46416) 2023-09-29 jacksongardner@google.com Use `dart:_wasm` constructs to avoid dependence on `WebAssembly.Function` (flutter/engine#46388) 2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 2d4045f55fd5 to a063eaeaf1e0 (6 revisions) (flutter/engine#46420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…5776) flutter/engine@48973d7...d203e34 2023-09-29 dkwingsmt@users.noreply.github.com Multi-view Rasterizer (flutter/engine#45512) 2023-09-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 955a3a964621 to 0931bb8a43c8 (1 revision) (flutter/engine#46423) 2023-09-29 jonahwilliams@google.com [Impeller] Redo simplify invert colors. (flutter/engine#46416) 2023-09-29 jacksongardner@google.com Use `dart:_wasm` constructs to avoid dependence on `WebAssembly.Function` (flutter/engine#46388) 2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 2d4045f55fd5 to a063eaeaf1e0 (6 revisions) (flutter/engine#46420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Now with fewer state bugs. Fixes flutter/flutter#135699
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with fewer state bugs.
Fixes flutter/flutter#135699