This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add dart2wasm dependency to flutter_frontend_server #45570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change https://dart-review.googlesource.com/c/sdk/+/323000 added a dependency on dart2wasm to the frontend_server package. Flutter engine has all dependencies in its source checkout, and paths to their locations hardcoded in the dependency_ovedrrides of flutter_frontend_server's pubspec.yaml. Add the dart2wasm package location to pubspec.yaml. Add the transitive dependency wasm_builder package lcoation to pubspec.yaml.
dcharkes
approved these changes
Sep 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 8, 2023
flutter/engine@a140ab4...f146d4b 2023-09-08 whesse@google.com Add dart2wasm dependency to flutter_frontend_server (flutter/engine#45570) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change
https://dart-review.googlesource.com/c/sdk/+/323000 added a dependency on dart2wasm to the frontend_server package.
Flutter engine has all dependencies in its source checkout, and paths to their locations hardcoded in the dependency_ovedrrides of flutter_frontend_server's pubspec.yaml.
Add the dart2wasm package location to pubspec.yaml. Add the transitive dependency wasm_builder package lcoation to pubspec.yaml.