This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Update xcode_frame_capture.md #45230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 29, 2023
Contributor
There was a problem hiding this comment.
Was this just a drive by change?
Contributor
Author
There was a problem hiding this comment.
so the original screen shot doesn't have the --enable_playground flag in it
Contributor
|
Sorry, didn't notice the image modification while reviewing on my phone. But was that necessary? |
Contributor
Author
|
In the new screen shot I include the --enable_playground flag |
Contributor
|
Ah, my bad. The image is half the size (perhaps captured on a non-hidpi device?) and I didn't look closely. All good. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2023
flutter/engine@1feb930...db3ecf8 2023-08-29 bdero@google.com [Impeller] Remove unused HasThreadingRestrictions capability. (flutter/engine#45242) 2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from fb09020ce62d to 8a2754a1ae60 (6 revisions) (flutter/engine#45241) 2023-08-29 47866232+chunhtai@users.noreply.github.com [Impeller] Update xcode_frame_capture.md (flutter/engine#45230) 2023-08-29 109111084+yaakovschectman@users.noreply.github.com Update documentation for updater callback. (flutter/engine#45239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.