This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Disable Impeller on Fuchsia #44925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some build variations, `is_mac` or `is_linux` is true, but `target_os == "fuchsia"`. We should explicitly disable Impeller in those variants. Fixes flutter/flutter#132793
chinmaygarde
approved these changes
Aug 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 22, 2023
flutter/engine@55b8426...e5929d8 2023-08-21 dnfield@google.com [Impeller] Disable Impeller on Fuchsia (flutter/engine#44925) 2023-08-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Added recycled command buffers. (flutter/engine#44904) 2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1859f7202bba to 00f6f69187df (1 revision) (flutter/engine#44922) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
In some build variations, `is_mac` or `is_linux` is true, but `target_os == "fuchsia"`. We should explicitly disable Impeller in those variants. Fixes flutter/flutter#132793
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some build variations,
is_macoris_linuxis true, buttarget_os == "fuchsia".We should explicitly disable Impeller in those variants.
Fixes flutter/flutter#132793