This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Conditionally enable HardwareBuffer backed platform views #44744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
reidbaker
approved these changes
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2023
flutter/engine@dbfe71c...12cafae 2023-08-16 john@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2023
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
Aug 16, 2023
…utter#44744)" This reverts commit 12cafae.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
…4744)" (#44785) This reverts commit 12cafae. The https://github.com/flutter/flutter/tree/master/dev/integration_tests/abstract_method_smoke_test test was not rendering the platform view with that change.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 17, 2023
flutter/engine@dbfe71c...5336702 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786) 2023-08-16 jason-simmons@users.noreply.github.com Revert "Conditionally enable HardwareBuffer backed platform views (#44744)" (flutter/engine#44785) 2023-08-16 dnfield@google.com [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782) 2023-08-16 john@johnmccutchan.com Switch some ERROR logs to WARNING logs (flutter/engine#44784) 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780) 2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770) 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778) 2023-08-16 matanlurey@users.noreply.github.com Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773) 2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777) 2023-08-16 louiseh0313@gmail.com Fix search web test (flutter/engine#44704) 2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GpKKtPGPMiRcY0kcz... to cPncZK6z8HmuOmQr_... (flutter/engine#44769) 2023-08-16 godofredoc@google.com Remove duplicated v1 builds. (flutter/engine#44767) 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768) 2023-08-16 zanderso@users.noreply.github.com Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763) 2023-08-16 john@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from GpKKtPGPMiRc to cPncZK6z8Hmu fuchsia/sdk/core/mac-amd64 from Zp9or9YwxZHH to VW7WAVPT3Cj5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…utter#44744)" (flutter#44785) This reverts commit 12cafae. The https://github.com/flutter/flutter/tree/master/dev/integration_tests/abstract_method_smoke_test test was not rendering the platform view with that change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android >= 29 we can use a more efficient platform view render target