This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[shell] Add references to VsyncWaiter docs #44607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point users in the direction of VsyncWaiterAndroid, VsyncWaiterEmbedder.
loic-sharma
approved these changes
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2023
flutter/engine@b019ac6...18a71c0 2023-08-10 chris@bracken.jp [shell] Add references to VsyncWaiter docs (flutter/engine#44607) 2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from b6492f5ce8c3 to b001e0a5e46f (1 revision) (flutter/engine#44606) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Point users in the direction of VsyncWaiterAndroid, VsyncWaiterEmbedder. No new tests since this patch introduces no semantic changes. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point users in the direction of VsyncWaiterAndroid, VsyncWaiterEmbedder.
No new tests since this patch introduces no semantic changes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.