This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support iOS scroll-to-top tap on iPhone X #4436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for scrolling the primary scroll view to the top on status bar touches, on the iPhone X. Notes: 1. The iPhone X status bar doesn't change height when in in-call/etc. mode, and unlike other iPhones, does scroll to top when in in-call mode. 2. No matter which model of iOS device, the top safe area inset doesn't change when in in-call mode. In in-call mode, the OS reduces the app view height by 20px off the top, and the double-height 'in-call' status bar covers the new OS (outside the view) and there continues to be a 20px safe area in the app. On iOS 11, rather than comparing status bar height to a hardcoded 20px 'standard height' it compares it to the top safe area inset (which is always the standard status bar height, regardless of device). On iOS versions earlier than iOS 11, it uses the previous logic. Fixes flutter/flutter#13439
chinmaygarde
approved these changes
Dec 9, 2017
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Dec 9, 2017
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Dec 9, 2017
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for scrolling the primary scroll view to the top on
status bar touches, on the iPhone X.
Notes:
mode, and unlike other iPhones, does scroll to top when in in-call mode.
change when in in-call mode. In in-call mode, the OS reduces the app
view height by 20px off the top, and the double-height 'in-call' status
bar covers this new inset (outside the view) and there continues to be a
20px safe area in the app.
On iOS 11, rather than comparing status bar height to a hardcoded 20px
'standard height' we now compare to the top safe area inset (which is
always the standard status bar height, regardless of device). On iOS
versions prior to iOS 11, we use the previous logic.
Fixes flutter/flutter#13439