This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Only use upstream vulkan headers #44157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16928b4 to
1d1dc94
Compare
1d1dc94 to
c42a1cc
Compare
chinmaygarde
approved these changes
Jul 31, 2023
c42a1cc to
b3b6e4d
Compare
5a6bf44 to
bb40bdc
Compare
Stop using the special fuchsia headers, as they are contributing to undefined behavior when building with LTO. They are also no longer needed. All relevant fuchsia extensions were upstreamed some time ago. In the process, engage in some cleanup which means the "vulkan_config" is also no longer needed. Rely on GN "public_deps" to provide the vulkan include paths to various source sets.
bb40bdc to
9bde0ca
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2023
flutter/engine@1433e23...7651b3c 2023-08-01 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0e02245635ea to a58ca112af1c (1 revision) (flutter/engine#44197) 2023-08-01 dworsham@google.com [fuchsia] Only use upstream vulkan headers (flutter/engine#44157) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
that referenced
this pull request
Aug 1, 2023
This is expected to be good-to-go following the fix in #44157
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
This is expected to be good-to-go following the fix in #44157
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…1648) flutter/engine@1433e23...7651b3c 2023-08-01 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0e02245635ea to a58ca112af1c (1 revision) (flutter/engine#44197) 2023-08-01 dworsham@google.com [fuchsia] Only use upstream vulkan headers (flutter/engine#44157) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Stop using the special fuchsia headers, as they are contributing to undefined behavior when building with LTO. They are also no longer needed. All relevant fuchsia extensions were upstreamed some time ago. In the process, engage in some cleanup which means the "vulkan_config" is also no longer needed. Rely on GN "public_deps" to provide the vulkan include paths to various source sets. See b/291462180 for more details on why this fix was neccesary.
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…r#44220) This is expected to be good-to-go following the fix in flutter#44157
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using the special fuchsia headers, as they are contributing to undefined behavior when building with LTO.
They are also no longer needed. All relevant fuchsia extensions were upstreamed some time ago.
In the process, engage in some cleanup which means the "vulkan_config" is also no longer needed. Rely on GN "public_deps" to provide the vulkan include paths to various source sets.
See b/291462180 for more details on why this fix was neccesary.