This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Unconditionally cache swapchain msaa texture. #43529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Jul 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 11, 2023
flutter/engine@daecd61...95316fb 2023-07-11 jonahwilliams@google.com [Impeller] Unconditionally cache swapchain msaa texture. (flutter/engine#43529) 2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from c3d39bed2830 to 76daa2a33fa5 (1 revision) (flutter/engine#43539) 2023-07-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4fmJ_PQoaE2L9vdx0... to cgcxIe8D4wb8hQWCV... (flutter/engine#43538) 2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 2db628aa1181 to c3d39bed2830 (1 revision) (flutter/engine#43537) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 4fmJ_PQoaE2L to cgcxIe8D4wb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Even on the Pixel 6 pro device which supports memoryless textures, I can observe creating the memoryless texture sometimes takes a few hundred microseconds, possibly due to stalls in the driver allocating the texture metadata. Lets just unconditionally cache this texture to avoid making the driver do more work. Here is an example of this happening:  flutter/flutter#129392
gbtb16
pushed a commit
to gbtb16/flutter
that referenced
this pull request
Nov 6, 2023
…0305) flutter/engine@daecd61...95316fb 2023-07-11 jonahwilliams@google.com [Impeller] Unconditionally cache swapchain msaa texture. (flutter/engine#43529) 2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from c3d39bed2830 to 76daa2a33fa5 (1 revision) (flutter/engine#43539) 2023-07-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4fmJ_PQoaE2L9vdx0... to cgcxIe8D4wb8hQWCV... (flutter/engine#43538) 2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 2db628aa1181 to c3d39bed2830 (1 revision) (flutter/engine#43537) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 4fmJ_PQoaE2L to cgcxIe8D4wb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even on the Pixel 6 pro device which supports memoryless textures, I can observe creating the memoryless texture sometimes takes a few hundred microseconds, possibly due to stalls in the driver allocating the texture metadata. Lets just unconditionally cache this texture to avoid making the driver do more work.
Here is an example of this happening:
flutter/flutter#129392