This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add matrix backdrop filter golden. #43484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jul 8, 2023
0efd586 to
76db407
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 10, 2023
flutter/engine@b328b03...7d054ab 2023-07-10 bdero@google.com [Impeller] Add matrix backdrop filter golden. (flutter/engine#43484) 2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 03e689a0fa32 to c06d7ef5c276 (1 revision) (flutter/engine#43520) 2023-07-10 robert.ancell@canonical.com Use better method of ensuring that *_get_type() functions are exported (flutter/engine#43395) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Adds an Aiks golden to demonstrate issues with using MatrixFilterContents as a backdrop filter.
gbtb16
pushed a commit
to gbtb16/flutter
that referenced
this pull request
Nov 6, 2023
…0287) flutter/engine@b328b03...7d054ab 2023-07-10 bdero@google.com [Impeller] Add matrix backdrop filter golden. (flutter/engine#43484) 2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 03e689a0fa32 to c06d7ef5c276 (1 revision) (flutter/engine#43520) 2023-07-10 robert.ancell@canonical.com Use better method of ensuring that *_get_type() functions are exported (flutter/engine#43395) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an Aiks golden to demonstrate issues with using MatrixFilterContents as a backdrop filter.
What should happen:
A single green circle should render at 200, 200 with a radius of 100.
What actually happens:
Each frame, a new green circle gets blit to the surface, starting at position 100, 100 and adding 100, 100 to the position every frame.
Screen.Recording.2023-07-07.at.4.56.21.PM.mov