This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add docs for magic variables. #43121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation for env variable substitution in test execution. Bug: flutter/flutter#129280
zanderso
reviewed
Jun 23, 2023
| the test). Magic environment variables have the following limitations: | ||
| only `${FLUTTER_LOGS_DIR}` is currently supported and it needs to be used | ||
| alone within the parameter string(e.g. `["${FLUTTER_LOGS_DIR}"]` is OK | ||
| but `["path=${FLUTTER_LOGS_DIR}"]` is not). |
Member
There was a problem hiding this comment.
Curious about the reason for this restriction. Could you point me at the implementation?
Contributor
Author
There was a problem hiding this comment.
The restriction is not technical, it was just to simplify the initial implementation. https://cs.opensource.google/flutter/recipes/+/main:recipes/engine_v2/builder.py;l=101
Member
There was a problem hiding this comment.
kk. Is there an issue filed to follow-up on that? Looping over the keys and doing a find/replace seems like a small, easy improvement.
Contributor
Author
There was a problem hiding this comment.
Created a tracking bug: flutter/flutter#129469
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 24, 2023
flutter/engine@5e6dcf9...240a86f 2023-06-24 godofredoc@google.com Add docs for magic variables. (flutter/engine#43121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for env variable substitution in test execution.
Bug: flutter/flutter#129280
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.