This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] default sample count back to 1 (but configure to 4 in defaults). #43089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
approved these changes
Jun 22, 2023
| *context, texture_size, SPrintF("%s Offscreen", label.c_str()), | ||
| RenderTarget::kDefaultColorAttachmentConfigMSAA, std::nullopt); | ||
| RenderTarget::kDefaultColorAttachmentConfigMSAA // | ||
| #ifndef FML_OS_ANDROID |
Member
There was a problem hiding this comment.
Mind adding another comment nearby about how keeping the stencil attachment is just to keep PSO variants to a minimum on Android (similar to the one below)?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 22, 2023
flutter/engine@703c9a1...ed477de 2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from bbcf54bcb738 to 4ed2d403a329 (7 revisions) (flutter/engine#43105) 2023-06-22 chingjun@google.com Workaround a release blocker after libc++ change (flutter/engine#43091) 2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102) 2023-06-22 bdero@google.com [Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093) 2023-06-22 bdero@google.com [Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094) 2023-06-22 103135467+sealesj@users.noreply.github.com Use minor version, ignore patches for CodeQL (flutter/engine#43088) 2023-06-22 dnfield@google.com Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928) 2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096) 2023-06-22 jonahwilliams@google.com [Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089) 2023-06-22 mdebbar@google.com [web] Don't get break type from v8BreakIterator (flutter/engine#43053) 2023-06-22 aam@google.com Roll dart to 3.1.0-239.0.dev (flutter/engine#43083) 2023-06-22 jonahwilliams@google.com Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061) 2023-06-22 jonahwilliams@google.com [Impeller] Add fence waiter trace event. (flutter/engine#43092) 2023-06-22 jonahwilliams@google.com [Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085) 2023-06-22 zanderso@users.noreply.github.com Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087) 2023-06-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081) 2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080) 2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from 7658525166a4 to bbcf54bcb738 (1 revision) (flutter/engine#43079) 2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 5013b651f8ec to 117f57a53215 (1 revision) (flutter/engine#43078) 2023-06-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QtQznuUmHMTyORqxJ... to Ylc35wOk0_j0NLzDv... (flutter/engine#43076) 2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from a2b3f9b64670 to 7658525166a4 (1 revision) (flutter/engine#43075) 2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from ac263582dda4 to a2b3f9b64670 (1 revision) (flutter/engine#43074) 2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 71047dca9f77 to 5013b651f8ec (4 revisions) (flutter/engine#43073) 2023-06-22 bdero@google.com [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 7EZeNE4aGd29 to tcVndpnH_jzG fuchsia/sdk/core/mac-amd64 from QtQznuUmHMTy to Ylc35wOk0_j0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also forces the creation of a stencil attachment always on Android to reduce the number of PSO variants.
flutter/flutter#129050