This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] use pixel format in construction of initial PSO objects, set default sample count to 4. #42972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2023
…jects, set default sample count to 4. (flutter/engine#42972)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 20, 2023
flutter/engine@1c16af7...06d0c08 2023-06-20 jason-simmons@users.noreply.github.com A few minor cleanups of the MultiFrameCodec (flutter/engine#42935) 2023-06-20 jonahwilliams@google.com [Impeller] use pixel format in construction of initial PSO objects, set default sample count to 4. (flutter/engine#42972) 2023-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from dc6691ef755c to 219b3198373c (1 revision) (flutter/engine#43005) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #42902
on iOS the default pixel format can change due to wide gamut + platform views introducing multiple surfaces. Cache the default options used to create all pipelines so that we can guarantee that one can be found.