This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] dont use concurrent runner to decode images on Android. #42944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 17, 2023
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
Just so I am understanding this right, the issue is that the device allocation as part of the concurrent decompression is causing slowdowns? I didn't think just the decompression touched any GPU resources.
Contributor
Author
|
My theory is that we're overloading the phone. There are a bunch of smaller potential problems too, from the PSO construction to the memory allocation for both the staging buffers and the textures ... If everything else was working well then I think it would be easier to identify the exact problems. For the time being, I'd propose that we simplify things and get the rest of the world in a working state. Then we can investigate whether concurrent upload/decompression is feasible. |
Contributor
|
Sounds good to me. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2023
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 19, 2023
flutter/engine@7ffa135...d298f0b 2023-06-18 jonahwilliams@google.com Fix prefer_final_in_foreach analysis errors (flutter/engine#42971) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xS5RzQLfpMEK1rNEd... to fgS2avQGq4x_sbZHU... (flutter/engine#42973) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from aBEyk5N2HlwOqvpwo... to BuzniDS9u_hdghV5f... (flutter/engine#42970) 2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from dc2e0ebbd045 to f489be63a30a (1 revision) (flutter/engine#42968) 2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from 85b4788bc3f1 to dc2e0ebbd045 (1 revision) (flutter/engine#42967) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -PsA0LDB2FdS_4_vK... to xS5RzQLfpMEK1rNEd... (flutter/engine#42966) 2023-06-18 bdero@google.com [Impeller] Use 32 bit for positional stuff in the rrect blur (flutter/engine#42797) 2023-06-18 jonahwilliams@google.com Revert "[Impeller] correct default PSO pixel format and sample count." (flutter/engine#42962) 2023-06-18 jonahwilliams@google.com [Impeller] dont use concurrent runner to decode images on Android. (flutter/engine#42944) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from I1G8Ll0KcxmAoMT8u... to aBEyk5N2HlwOqvpwo... (flutter/engine#42964) 2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from c56f38d79fe0 to 85b4788bc3f1 (2 revisions) (flutter/engine#42963) 2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d1faf69c8253 to 5a9e97eebbed (1 revision) (flutter/engine#42958) 2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from 2a9e11fd9d37 to c56f38d79fe0 (1 revision) (flutter/engine#42955) 2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JMStJe6efcLuWMT_I... to I1G8Ll0KcxmAoMT8u... (flutter/engine#42954) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 1a04f451a934 to d1faf69c8253 (1 revision) (flutter/engine#42953) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from b3bcbdf7de8d to 1a04f451a934 (1 revision) (flutter/engine#42951) 2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from dc11c7ddb33f to 2a9e11fd9d37 (1 revision) (flutter/engine#42950) 2023-06-17 bdero@google.com [Impeller] Print malioc errors on CI (flutter/engine#42906) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 8eaed3382237 to b3bcbdf7de8d (10 revisions) (flutter/engine#42949) 2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -NW1eatBbmjvLaIcV... to Au1gd3XLMuSt1Z4oh... (flutter/engine#42948) 2023-06-17 a-siva@users.noreply.github.com Fix analyzer warnings (prefer_final_in_for_each is now the default) (flutter/engine#42943) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fXVcR5tdj5wSd_OUz... to JMStJe6efcLuWMT_I... (flutter/engine#42942) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 64fa632d3b01 to dc11c7ddb33f (3 revisions) (flutter/engine#42939) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from -NW1eatBbmjv to fgS2avQGq4x_ fuchsia/sdk/core/mac-amd64 from fXVcR5tdj5wS to BuzniDS9u_hd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with separate allocators and queues, I think that using the concurrent runner is just overloading the phone.
On Android force it all onto the I/O thread.
flutter/flutter#128919