Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

Fixes flutter/flutter#128448 (comment)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@drewroengoogle drewroengoogle added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023
@auto-submit auto-submit bot merged commit 329bff3 into main Jun 7, 2023
@auto-submit auto-submit bot deleted the CaseyHillers-patch-3 branch June 7, 2023 20:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 7, 2023
flutter/engine@1089ce6...a5f7d5d

2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from c5a8c4547f59 to 156542f8bf13 (4 revisions) (flutter/engine#42641)
2023-06-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 7.3.0 (flutter/engine#42629)
2023-06-07 zhangzhijian.123@bytedance.com [Impeller] Corrected the 'texture_coords' computation in 'Geometry::GetPositionUVBuffer' (flutter/engine#42619)
2023-06-07 aam@google.com Roll dart to 3.1.0-171.0.dev (flutter/engine#42636)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 773765ca1dd2 to c5a8c4547f59 (4 revisions) (flutter/engine#42633)
2023-06-07 godofredoc@google.com Add global test docs. (flutter/engine#42531)
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ojwVlxZWrbsG4WGSE... to DL1QQ5eZRVNARqLx-... (flutter/engine#42632)
2023-06-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sEHtHM1iFt79roP-x... to aMTaMP0DdKdJnxSbc... (flutter/engine#42631)
2023-06-07 chillers@google.com [labeler] Fix to run on flutter/engine (flutter/engine#42634)
2023-06-07 leroux_bruno@yahoo.fr [iOS] Fix TextInputAction.continueAction sends wrong action to framework (flutter/engine#42615)
2023-06-07 jonahwilliams@google.com [Impeller] fix missing assignment of embedder render target. (flutter/engine#42630)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from sEHtHM1iFt79 to aMTaMP0DdKdJ
  fuchsia/sdk/core/mac-amd64 from ojwVlxZWrbsG to DL1QQ5eZRVNA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

labeler action is being skipped on flutter/engine

2 participants