Revert Dart SDK to 3.1.0-166.0.dev #42568
Conversation
…isions) (flutter#42557)" This reverts commit dc15d97.
…isions) (flutter#42535)" This reverts commit 7168c11.
|
In particular, it looks like expression evaluation tests are timing out: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20tool_integration_tests_3_4/23308/overview |
|
More than likely the roll needs flutter/flutter#128084, which have matching changes to the list of expression evaluation request arguments |
I don't have any concrete suggestions about how to go about it, but it generally causes a lot less disruption to do soft-breaking changes when possible. Just a wild guess, but it looks like in this case, the service protocol could maybe have been made robust against the new parameters being missing? |
My intent was to include quoted PR into the roll. |
We do have the ability to patch rolls, but my view is that that is more for emergencies rather than our regular way of doing things. When the rollers get blocked up, it has a bunch of bad effects downstream, so we should be trying really hard to avoid that. |
|
flutter/flutter#128255 with engine roll and patch to expression evaluation invocation(flutter/flutter#128084) passes the tests. |
flutter/engine@c838a1b...f9f7238 2023-06-05 zanderso@users.noreply.github.com Revert Dart SDK to 3.1.0-166.0.dev (flutter/engine#42568) 2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a10e944601cf to a226cfbd6cc7 (1 revision) (flutter/engine#42562) 2023-06-05 kjlubick@users.noreply.github.com Add missing includes of GrBackendSurface.h (flutter/engine#42563) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.5 to 2.3.6 (flutter/engine#42561) 2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from 210ad9cde42b to a10e944601cf (3 revisions) (flutter/engine#42560) 2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sk-SFXAARqkT7wGmf... to fgfgAhpxFpse7Xi4i... (flutter/engine#42558) 2023-06-05 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d00a370c1fd3 to 5144119b99c8 (2 revisions) (flutter/engine#42557) 2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 839LDf0p1Q4wyszA5... to gp1k1agqxQIz0oTXV... (flutter/engine#42553) 2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5pFMQIRHNENhekRDO... to sk-SFXAARqkT7wGmf... (flutter/engine#42551) 2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 8ca7bad9158f to 210ad9cde42b (1 revision) (flutter/engine#42549) 2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 611132d6ab8c to 8ca7bad9158f (1 revision) (flutter/engine#42548) 2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bb9z8SjSCzRN6SVee... to 839LDf0p1Q4wyszA5... (flutter/engine#42544) 2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vVgQ12wNh2DIT_hV7... to 5pFMQIRHNENhekRDO... (flutter/engine#42543) 2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 0e80a97ccee3 to 611132d6ab8c (2 revisions) (flutter/engine#42542) 2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 98da8d7a299d to 0e80a97ccee3 (1 revision) (flutter/engine#42541) 2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VtLnfLmVda1_h1AtM... to Bb9z8SjSCzRN6SVee... (flutter/engine#42538) 2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 656de7fc6994 to 98da8d7a299d (1 revision) (flutter/engine#42537) 2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gcm-vsCu6IPUZZnN0... to vVgQ12wNh2DIT_hV7... (flutter/engine#42536) 2023-06-03 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d198f84f5e4e to d00a370c1fd3 (3 revisions) (flutter/engine#42535) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VtLnfLmVda1_ to gp1k1agqxQIz fuchsia/sdk/core/mac-amd64 from gcm-vsCu6IPU to fgfgAhpxFpse If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Rolls to the Framework are failing repeatedly in tool integration tests since the attempt at flutter/flutter#128168