This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement PlatformDispatcher.displays on web #42297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdblasi-google
approved these changes
May 24, 2023
Contributor
pdblasi-google
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the quick turnaround!
yjbanov
approved these changes
May 24, 2023
| id: 0, | ||
| size: ui.Size(domWindow.screen?.width ?? 0, domWindow.screen?.height ?? 0), | ||
| devicePixelRatio: domWindow.devicePixelRatio, | ||
| refreshRate: 60, |
There was a problem hiding this comment.
Could it be bigger on MacOS/Safari with ProMotion display?
Contributor
Author
There was a problem hiding this comment.
Yes - but there's not a good web API to measure this, so for now it's just getting defaulted to 60.
Contributor
Author
There was a problem hiding this comment.
If you're interested in improving this, see e.g. https://stackoverflow.com/questions/6131051/is-it-possible-to-find-out-what-is-the-monitor-frame-rate-in-javascript - but I'm not sure how we'd do that without being pretty flaky.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 25, 2023
flutter/engine@195009b...515a4bf 2023-05-25 dnfield@google.com Implement PlatformDispatcher.displays on web (flutter/engine#42297) 2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from b80e74dc4cda to 69d0aa065992 (3 revisions) (flutter/engine#42319) 2023-05-25 bdero@google.com [Impeller] Safely access snapshot in the pipeline blend filter (flutter/engine#42314) 2023-05-25 bdero@google.com [Impeller] Add generic path for mask blurring (flutter/engine#42308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this before.