This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Do not bounce editing state back to framework on setEditState #42091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4675f7e to
0a10d3e
Compare
… verify the editing state
justinmc
approved these changes
May 25, 2023
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍.
I'm glad to see this go! Have you tested it locally just to make sure nothing obvious breaks?
LongCatIsLooong
approved these changes
May 26, 2023
Contributor
Author
Yeah nothing obvious broke, I tried CJK input as well and seems to be working as expected. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 26, 2023
flutter/engine@3b5b5fc...795db50 2023-05-26 rmolivares@renzo-olivares.dev [macOS] Do not bounce editing state back to framework on setEditState (flutter/engine#42091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context for this change flutter/flutter#118642 (comment) and flutter/flutter#118759 (comment) . Tldr, the use-case that this bouncing was originally introduced for in #13702 is no longer an issue.
This ack response is also not present on other desktop platforms or iOS.
Fixes #118759 and #118642
Pre-launch Checklist
///).