This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Ensure that embedded blobs are placed at aligned addresses. #41526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 28, 2023
impeller/tools/xxd.py
Outdated
| output.write(f'#include "{output_header_basename}"\n') | ||
| output.write(f'const unsigned char impeller_{args.symbol_name}_data[] =\n') | ||
| output.write( | ||
| f'alignas(8) const unsigned char impeller_{args.symbol_name}_data[] =\n' |
Contributor
There was a problem hiding this comment.
This should probably be alignas(long double).
Contributor
There was a problem hiding this comment.
Ooh, found this. So alignas(std::max_align_t) for maximum portability.
fa6d796 to
8b5677a
Compare
FlatBuffer deserialization may segfault if the buffer is based at an unaligned address.
8b5677a to
9c08adc
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 28, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 29, 2023
flutter/engine@1ae848c...3835d97 2023-04-28 jason-simmons@users.noreply.github.com [Impeller] Ensure that embedded blobs are placed at aligned addresses. (flutter/engine#41526) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlatBuffer deserialization may segfault if the buffer is based at an unaligned address.