Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented Apr 11, 2023

Helps make alpha refactors easier.

@bdero bdero self-assigned this Apr 11, 2023
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #41095 at sha 9778cd0

@bdero bdero force-pushed the bdero/alpha-goldens branch from 9778cd0 to fc32cdb Compare April 12, 2023 01:54
@bdero bdero changed the title [Impeller] Convert alpha management playgrounds into goldens [Impeller] Convert SaveLayer alpha playgrounds into goldens Apr 12, 2023
@bdero bdero force-pushed the bdero/alpha-goldens branch from d1cf98a to 01f627c Compare April 12, 2023 02:19
@bdero bdero requested review from jonahwilliams and zanderso April 12, 2023 02:22
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #41095 at sha 01f627c

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit auto-submit bot merged commit 424be4d into flutter:main Apr 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2023
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
…41095)

[Impeller] Convert SaveLayer alpha playgrounds into goldens
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller will affect goldens

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants