This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Make validation logs non-fatal by default. #40855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will still be fatal in tests and no logs will show up in release. Fixes flutter/flutter#123884 In fixing the linked issue, I didn't want to risk us having a stray validation log tear down the release process. This is safer and gets us the information we need during development.
zanderso
approved these changes
Apr 1, 2023
| return; | ||
| } | ||
|
|
||
| ImpellerValidationErrorsSetFatal(true); |
Member
There was a problem hiding this comment.
Will this also be set during golden tests?
Contributor
Author
There was a problem hiding this comment.
Yes. The golden tests use the same playgrounds harnesses.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will still be fatal in tests and no logs will show up in release.
Fixes flutter/flutter#123884
In fixing the linked issue, I didn't want to risk us having a stray validation log tear down the release process. This is safer and gets us the information we need during development.