Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix default test font on web #40479

Merged
auto-submit merged 8 commits into from
Mar 23, 2023
Merged

Fix default test font on web #40479

auto-submit merged 8 commits into from
Mar 23, 2023

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Mar 21, 2023 •
edited
Loading

Reorder test fonts to make FlutterTest the default on web and fix typo

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 21, 2023
@LongCatIsLooong LongCatIsLooong marked this pull request as draft March 21, 2023 07:04
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 21, 2023

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@LongCatIsLooong LongCatIsLooong force-pushed the default-font-web branch 2 times, most recently from 4dd7ae6 to 5884e00 Compare March 21, 2023 18:21
@LongCatIsLooong LongCatIsLooong force-pushed the default-font-web branch 6 times, most recently from 84d09c4 to 254dae4 Compare March 23, 2023 15:59
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review March 23, 2023 17:44
@LongCatIsLooong LongCatIsLooong requested a review from mdebbar March 23, 2023 17:44
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 23, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #40479 at sha 254dae4

mdebbar
mdebbar approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LongCatIsLooong @mdebbar
Update lib/web_ui/test/text_test.dart
955918e 
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 23, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 23, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 23, 2023

auto label is removed for flutter/engine, pr: 40479, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 23, 2023
@auto-submit auto-submit bot merged commit 1da070c into flutter:main Mar 23, 2023
@LongCatIsLooong LongCatIsLooong deleted the default-font-web branch March 23, 2023 22:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
1da070c Fix default test font on web (flutter/engine#40479)
a89e25d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mdebbar mdebbar mdebbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @mdebbar