Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Mar 9, 2023

Refactor the platform_message_handler_ios:

  1. Move @FlutterTaskQueue to header
  2. Change the constructor only requires the platform task runner instead of the task_runners. Making this change so that we can use PlatformMessageHandlerIos while migrating to the embedder api. The embedder won't have access to the task_runners when using embedder api, but will have access to the platform task runner.
  3. Minor: move impelmentation of DoesHandlePlatformMessageOnPlatformThread to the .mm file.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz marked this pull request as ready for review March 9, 2023 18:49
@cyanglaz cyanglaz requested a review from gaaclarke March 9, 2023 18:49
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 9, 2023

auto label is removed for flutter/engine, pr: 40182, due to - The status or check suite Windows Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot merged commit 15a9ec7 into flutter:main Mar 9, 2023
@cyanglaz cyanglaz deleted the ios_platform_message_refactor branch March 9, 2023 21:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants