This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] all vertex UBOs now named FrameInfo, all fragment ubos now named FragInfo #39869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Feb 25, 2023
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
I had imagined we'd have multiple calls (or at least stages) sharing the same uniform blocks. But we never ended up doing any of that and uniform data size is towards the bottom of list of things we care about. So much for that idea.
| vec2 half_texel; | ||
| } | ||
| gradient_info; | ||
| frag_info; |
Contributor
There was a problem hiding this comment.
I don't know why clang-format puts this on a new line like this. Oh well.
Contributor
Author
|
we can always change it later on if we get to it. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 25, 2023
…bos now named FragInfo (flutter/engine#39869)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 25, 2023
…bos now named FragInfo (flutter/engine#39869)
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Feb 27, 2023
…named FragInfo (flutter#39869) [Impeller] all vertex UBOs now named FrameInfo, all fragment ubos now named FragInfo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all fragment shader UBOs and vertex shader UBOs consistent.