[Impeller] Avoid printing inactionable warning from Metal compiler #39859
Conversation
|
auto label is removed for flutter/engine, pr: 39859, due to - The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
I am also realizing that a simpler way to deal with this is to just use |
|
auto label is removed for flutter/engine, pr: 39859, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chinmaygarde
left a comment
There was a problem hiding this comment.
The test failures are complaining about the formatting of the python file. Other than that, I don't mind dropping all stdout/stderr too. We might end up making it harder to debug in case of failure but that is just a theoretical concern.
|
It'll still print stderr/stdout on failure, just not print anything on success |
|
I really thought I ran the format script on this but maybe not. Either way I've simplified the change a bit so that it will still print out if the command fails, but won't print out warnings/stdout unless the process has a non-zero exit code. |
No description provided.