This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Wire up a playground that can run Dart #39805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3767843 to
592ac27
Compare
chinmaygarde
approved these changes
Feb 22, 2023
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
once I figured out the fixture/dart kernel situation
Yeah, this one grew out of the initial setup just for unit-tests.
592ac27 to
e6b34bb
Compare
Contributor
|
OMG. I would love to not have to write tests in C++ if they're intended to be end2end ish tests. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 23, 2023
* 952a89b [Impeller] Wire up a playground that can run Dart (flutter/engine#39805) * d4bae28 [Impeller] Add PolygonMode to render layer (flutter/engine#39810)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took a bit of tinkering, but once I figured out the fixture/dart kernel situation and got everything to happen in the right order, the minimal solution turned out to be pretty simple.