This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Skia from d85501fa487d to 9cc86b2a4f27 (2 revisions) #39589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/d85501fa487d..9cc86b2a4f27 2023-02-13 kjlubick@google.com Add fall-back binary search for cubic roots when splitting 2023-02-13 kjlubick@google.com Add test cases in preparation for porting binary search cubic solution If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
981f089 to
f882565
Compare
fluttergithubbot
approved these changes
Feb 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 13, 2023
* 8cacce9 Roll Skia from d85501fa487d to 9cc86b2a4f27 (2 revisions) (flutter/engine#39589) * df0ffe4 Roll Fuchsia Linux SDK from R6oclCbqlvHdyGgut... to 5b_BYTPWG1E7qx1I8... (flutter/engine#39590)
0xZOne
pushed a commit
to 0xZOne/engine
that referenced
this pull request
Feb 20, 2023
) https://skia.googlesource.com/skia.git/+log/d85501fa487d..9cc86b2a4f27 2023-02-13 kjlubick@google.com Add fall-back binary search for cubic roots when splitting 2023-02-13 kjlubick@google.com Add test cases in preparation for porting binary search cubic solution If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/d85501fa487d..9cc86b2a4f27
2023-02-13 kjlubick@google.com Add fall-back binary search for cubic roots when splitting
2023-02-13 kjlubick@google.com Add test cases in preparation for porting binary search cubic solution
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md