This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Add web support for FragmentProgram #37065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Oct 27, 2022
jonahwilliams
commented
Oct 27, 2022
jonahwilliams
commented
Oct 27, 2022
jonahwilliams
commented
Oct 27, 2022
Comment on lines
373
to
381
| @override | ||
| SkShader createDefault() { | ||
| return MakeRuntimeEffect(source).makeShader(floats); | ||
| } | ||
|
|
||
| @override | ||
| SkShader resurrect() { | ||
| return MakeRuntimeEffect(source).makeShader(floats); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I don't really understand these APIs, I'm sure that I'm not using the correctly.
harryterkelsen
suggested changes
Oct 31, 2022
Contributor
harryterkelsen
left a comment
There was a problem hiding this comment.
Please add some tests for RuntimeEffect in canvaskit_api_test.dart
jonahwilliams
commented
Oct 31, 2022
Contributor
Author
jonahwilliams
left a comment
There was a problem hiding this comment.
There is a test that creates a RuntimeEffect object - but we don't ever support user supplied SkSL (and we never will). I could generate a small valid SkSL program locally and/or pull it out of an IPLR file to allow writing a test. Is that what you are looking for?
80baad3 to
e302781
Compare
Contributor
Author
|
Updated to use some simple SkSL programs and the RuntimeEffect API |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#114121
Downloads and parses the JSON formatted IPLR file generated by the flutter tooling. Allows creating RuntimeEffect objects and associated fragment shader programs if this is defined on the canvaskit object