Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Specify the min simulator version. #36809

Merged
auto-submit merged 1 commit into from
Oct 17, 2022
Merged

[Impeller] Specify the min simulator version. #36809

auto-submit merged 1 commit into from
Oct 17, 2022

Conversation

@chinmaygarde
Copy link
Contributor

@chinmaygarde chinmaygarde commented Oct 17, 2022

@chinmaygarde chinmaygarde requested a review from zanderso October 17, 2022 20:29
zanderso
zanderso reviewed Oct 17, 2022
View reviewed changes
impeller/tools/build_metal_library.py
# see https://github.com/flutter/flutter/issues/106066
command += [
'--std=ios-metal1.2',
'-mios-version-min=10.0',
Copy link
Member

@zanderso zanderso Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be 11.0?

Copy link
Contributor Author

@chinmaygarde chinmaygarde Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, may I change it in a later patch though? It is unrelated to the sim fix.

Copy link
Contributor Author

@chinmaygarde chinmaygarde Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to remove the workaround around optimizations that were making Xcode crashy. This script is looking a bit confusing now.

@chinmaygarde
Copy link
Contributor Author

chinmaygarde commented Oct 17, 2022

@zanderso I've tried to test this on hosts I have on hand but they were working before too. I am unable to remote into my desktop in the office that I am pretty sure will tickle the error. If you are able to test this fixes the error, I'd appreciate a sanity check. This builds and works just fine.

@chinmaygarde chinmaygarde self-assigned this Oct 17, 2022
zanderso
zanderso approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for me locally, and the validation errors now no longer show up in the scenario test logs https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8800025623849152401/+/u/test:_Scenario_App_Integration_Tests/stdout?format=raw

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2022
@auto-submit auto-submit bot merged commit 54109e3 into flutter:main Oct 17, 2022
@chinmaygarde chinmaygarde deleted the minsim branch October 17, 2022 21:27
@zanderso zanderso mentioned this pull request Oct 17, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2022
@engine-flutter-autoroll
54109e3 [Impeller] Specify the min simulator version. (flutter/engine…
f6c3e9f 
…#36809)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2022
@engine-flutter-autoroll
54109e3 [Impeller] Specify the min simulator version. (flutter/engine…
088b6ef 
…#36809)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chinmaygarde chinmaygarde

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Impeller failing on iOS simulator

2 participants

@chinmaygarde @zanderso