-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll vulkan-deps #36769
Roll vulkan-deps #36769
Conversation
|
auto label is removed for flutter/engine, pr: 36769, due to - The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
FYI I'm working on rolling to the latest ANGLE version in this WIP PR: #36389. Here are blockers I'm aware of:
My recommendation would be to try to roll to the non-latest versions to avoid these issues. |
|
I think I've found the earliest ANGLE commit that has the vulkan-deps commit we needed. I did some searching with @loic-sharma I'm taking a slightly different approach to resolving the unguarded availability -we don't actually use the Metal EXT stuff so I'm just undefining that before including vulkan.h. I'll file something upstream in vulkan headers to see if we can get availability guards to flow through eventually. |
|
Unfortunately this commit is making Windows unhappy. Going to try to just rev vulkan-deps to the earliest commit that has the change that fixes the macOS deprecations when building for Android. |
|
Just revving vulkan-headers a little bit seems to be passing CI. That's enough to fix one of our problems. |
Fixes flutter/flutter#112248