Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Oct 14, 2022

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 14, 2022

auto label is removed for flutter/engine, pr: 36769, due to - The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@loic-sharma
Copy link
Member

FYI I'm working on rolling to the latest ANGLE version in this WIP PR: #36389. Here are blockers I'm aware of:

  1. ANGLE is affected by an MSVC bug, we need to update to VS 2019 or newer: angleproject#7693
  2. Updating to VS 2019 exposes a bug in EventChannel which causes framework tests to fail, see: [Windows] Fix stack corruption issues flutter#113135 (comment)
  3. The latest version of SPIRV Cross generates invalid shader programs, breaking engine tests. See: GLSL's merge to direct for loop is regressed KhronosGroup/SPIRV-Cross#2031
  4. Lots of smaller miscellaneous things, see: Roll ANGLE, vulkan-deps, and shaderc #36389

My recommendation would be to try to roll to the non-latest versions to avoid these issues.

@dnfield dnfield changed the title Roll angle, swiftshader, shaderc, vulkan-deps Roll angle, vulkan-deps Oct 16, 2022
@dnfield
Copy link
Contributor Author

dnfield commented Oct 16, 2022

I think I've found the earliest ANGLE commit that has the vulkan-deps commit we needed. I did some searching with git grep and git rev-list. I probably could have rolled vulkan-deps out of sync with ANGLE, but trying to avoid that if this can pass CI.

@loic-sharma I'm taking a slightly different approach to resolving the unguarded availability -we don't actually use the Metal EXT stuff so I'm just undefining that before including vulkan.h. I'll file something upstream in vulkan headers to see if we can get availability guards to flow through eventually.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 16, 2022

Unfortunately this commit is making Windows unhappy. Going to try to just rev vulkan-deps to the earliest commit that has the change that fixes the macOS deprecations when building for Android.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2022
@dnfield
Copy link
Contributor Author

dnfield commented Oct 16, 2022

Just revving vulkan-headers a little bit seems to be passing CI. That's enough to fix one of our problems.

@dnfield dnfield changed the title Roll angle, vulkan-deps Roll vulkan-deps Oct 16, 2022
@auto-submit auto-submit bot merged commit f82c171 into flutter:main Oct 16, 2022
@dnfield dnfield deleted the roll_angle branch October 16, 2022 23:52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local android builds failing on spirv-cross

3 participants