Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[canvaskit] Maintain a Surface dedicated to Picture.toImage #36740

Merged
auto-submit merged 4 commits into from
Oct 13, 2022
Merged

[canvaskit] Maintain a Surface dedicated to Picture.toImage #36740

auto-submit merged 4 commits into from
Oct 13, 2022

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Oct 13, 2022

Fixes flutter/flutter#113094

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Oct 13, 2022
yjbanov
yjbanov approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 13, 2022
@auto-submit auto-submit bot merged commit 2bdfc1e into flutter:main Oct 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2022
@engine-flutter-autoroll
2bdfc1e [canvaskit] Maintain a Surface dedicated to Picture.toImage (f…
b552109 
…lutter/engine#36740)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@yjbanov yjbanov yjbanov approved these changes

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Picture.toImage does not release WebGL context on dispose in CanvasKit 3.4.x / 3.5.x

3 participants

@harryterkelsen @yjbanov @eyebrowsoffire