This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add polyline benchmark with lots of cubics and quads. #36731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gold has detected about 1 new digest(s) on patchset 3. |
Contributor
|
Do the values of the control points of the curves matter to the benchmark? Perhaps you can generate them with something like a Mersenne twister engine with a set seed. Then have that seed be parameterized in the benchmark. May just make the benchmark more readable and allow for greater combination and configurability. |
chinmaygarde
approved these changes
Oct 13, 2022
Contributor
Author
|
The values should be stable from one run to another. |
Contributor
Author
|
I'm realizing we'll also want a benchmark that includes tessellation, since it may otherwise be hard to tell whether a point reduction will beh elpful or not. |
Contributor
With a specific seed, they will be. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a benchmark for creating polylines.
I have a WIP patch locally that vastly improves quadratics and should be extensible to improve cubics as well. Want to land this first to have some data about how much improvement we're talking about.