Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Guard accessibility_bridge UIView access #36580

Merged
auto-submit merged 2 commits into from
Oct 4, 2022
Merged

Guard accessibility_bridge UIView access #36580

auto-submit merged 2 commits into from
Oct 4, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 4, 2022

Instead of loading the viewController.view in ~AccessibilityBridge, which crashed if the view was not already loaded, use viewIfLoaded.

Fixes flutter/flutter#112545

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 4, 2022
jmagman
jmagman commented Oct 4, 2022
View reviewed changes
shell/platform/darwin/ios/framework/Source/accessibility_bridge_test.mm
flutterPlatformViewsController->Reset();
}
XCTAssertNil(gMockPlatformView);
XCTAssertNil(flutterViewController.viewIfLoaded);
Copy link
Member Author

@jmagman jmagman Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check fails on master.

@jmagman
Copy link
Member Author

jmagman commented Oct 4, 2022

Need to investigate:

Test Case '-[FlutterEnginePlatformViewTest testCallsNotifyLowMemory]' started.
2022-10-03 18:34:09.081 xcodebuild[90050:1104698] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot8/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-21330/IDEFoundation/ProjectModel/ActionRecords/IDESchemeActionTestAttachment.m:168
Details:  Error writing attachment data to file /Users/chrome-bot/Library/Developer/Xcode/DerivedData/IosUnitTests-gvzhnbcayzcjrsfbbkjkkcswuina/Logs/Test/Test-IosUnitTests-2022.10.03_18-33-25--0700.xcresult/Staging/1_Test/Attachments/IosUnitTests_Oct 3, 2022 at 63408 PM PDT_0_26FCE9CA-3F61-4D9D-8A5C-E2A16505EBFB.ips: Error Domain=NSCocoaErrorDomain Code=4 "The file “IosUnitTests_Oct 3, 2022 at 63408 PM PDT_0_26FCE9CA-3F61-4D9D-8A5C-E2A16505EBFB.ips” doesn’t exist." UserInfo={NSFilePath=/Users/chrome-bot/Library/Developer/Xcode/DerivedData/IosUnitTests-gvzhnbcayzcjrsfbbkjkkcswuina/Logs/Test/Test-IosUnitTests-2022.10.03_18-33-25--0700.xcresult/Staging/1_Test/Attachments/IosUnitTests_Oct 3, 2022 at 63408 PM PDT_0_26FCE9CA-3F61-4D9D-8A5C-E2A16505EBFB.ips, NSUnderlyingError=0x600002bf9f50 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Object:   <IDESchemeActionTestAttachment: 0x600000868480>
Method:   -_savePayload:
Thread:   <_NSMainThread: 0x600003230440>{number = 1, name = main}
Please file a bug at https://feedbackassistant.apple.com/ with this warning message and any useful information you can provide.
2022-10-03 18:34:09.092 xcodebuild[90050:1104698] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot8/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-21330/IDEFoundation/ProjectModel/ActionRecords/IDESchemeActionTestAttachment.m:168
Details:  Error writing attachment data to file /Users/chrome-bot/Library/Developer/Xcode/DerivedData/IosUnitTests-gvzhnbcayzcjrsfbbkjkkcswuina/Logs/Test/Test-IosUnitTests-2022.10.03_18-33-25--0700.xcresult/Staging/1_Test/Attachments/IosUnitTests_Oct 3, 2022 at 63408 PM PDT_0_26FCE9CA-3F61-4D9D-8A5C-E2A16505EBFB.ips: Error Domain=NSCocoaErrorDomain Code=4 "The file “IosUnitTests_Oct 3, 2022 at 63408 PM PDT_0_26FCE9CA-3F61-4D9D-8A5C-E2A16505EBFB.ips” doesn’t exist." UserInfo={NSFilePath=/Users/chrome-bot/Library/Developer/Xcode/DerivedData/IosUnitTests-gvzhnbcayzcjrsfbbkjkkcswuina/Logs/Test/Test-IosUnitTests-2022.10.03_18-33-25--0700.xcresult/Staging/1_Test/Attachments/IosUnitTests_Oct 3, 2022 at 63408 PM PDT_0_26FCE9CA-3F61-4D9D-8A5C-E2A16505EBFB.ips, NSUnderlyingError=0x600002b8a0d0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Object:   <IDESchemeActionTestAttachment: 0x6000009c9680>
Method:   -_savePayload:
Thread:   <_NSMainThread: 0x600003230440>{number = 1, name = main}
Please file a bug at https://feedbackassistant.apple.com/ with this warning message and any useful information you can provide.
IosUnitTests(90305,0x1098f4600) malloc: enabling scribbling to detect mods to free blocks
IosUnitTests(90305) MallocStackLogging: could not tag MSL-related memory as no_footprint, so those pages will be included in process footprint - (null)
IosUnitTests(90305) MallocStackLogging: stack logs being written to /tmp/stack-logs.90305.1023c1000.IosUnitTests.ELNRo0.index
IosUnitTests(90305) MallocStackLogging: recording malloc and VM allocation stacks to disk using standard recorder
IosUnitTests(90305) MallocStackLogging: process 90265 no longer exists, stack logs deleted from /tmp/stack-logs.90265.10ab6d000.IosUnitTests.uZPzSI.index

Restarting after unexpected exit, crash, or test timeout in -[FlutterEnginePlatformViewTest testCallsNotifyLowMemory]; summary will include totals from previous launches.

@jmagman jmagman mentioned this pull request Oct 4, 2022
Closed
@jmagman jmagman force-pushed the access-bridge-view branch from e5e54a5 to 620add5 Compare October 4, 2022 20:29
@jmagman jmagman force-pushed the access-bridge-view branch from 620add5 to a224571 Compare October 4, 2022 22:04
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2022
@auto-submit auto-submit bot merged commit 271705d into flutter:main Oct 4, 2022
@jmagman jmagman deleted the access-bridge-view branch October 4, 2022 22:58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
271705d Guard accessibility_bridge UIView access (flutter/engine#36580)
575de2c
@ghost ghost mentioned this pull request Nov 18, 2022
Closed
@jmagman jmagman mentioned this pull request Dec 13, 2022
Merged
57 tasks
XilaiZhang pushed a commit to XilaiZhang/engine that referenced this pull request Dec 13, 2022
@jmagman @XilaiZhang
Guard accessibility_bridge UIView access (flutter#36580)
8b81461
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iOS] Crashed: com.apple.main-thread - [FlutterEngine iosPlatformView]

2 participants

@jmagman @chinmaygarde