This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use strip_bitcode for create_arm_gen_snapshot #36510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Sep 29, 2022
This migrates the `create_arm_gen_snapshot` target used to create a copy of gen_snapshot suffixed with its target CPU architecture using the same `strip_bitcode` macro used for the equivalent target used for desktop gen_snapshot. In a followup patch, these will be merged to a single target. They currently still have incompatible output paths. Issue: flutter/flutter#103386 Issue: flutter/flutter#101138 Issue: flutter/flutter#107884
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2022
This was referenced Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the
create_arm_gen_snapshottarget used to create a copy of gen_snapshot suffixed with its target CPU architecture using the samestrip_bitcodemacro used for the equivalent target used for desktop gen_snapshot.In a followup patch, these will be merged to a single target. They currently still have incompatible output paths.
Issue: flutter/flutter#103386
Issue: flutter/flutter#101138
Issue: flutter/flutter#107884
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.