Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@a-siva
Copy link
Contributor

@a-siva a-siva commented Sep 23, 2022

Remove the @Dart language versioning from all the files so that this code runs in strong null safe mode.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@a-siva
Copy link
Contributor Author

a-siva commented Sep 23, 2022

This PR does not make any fixes, it is only removing the language version specifications which would make the code run in strong null safe mode, all the existing tests would test would continue to work.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2022
@auto-submit auto-submit bot merged commit 01fca5e into flutter:main Sep 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2022
@a-siva
Copy link
Contributor Author

a-siva commented Sep 26, 2022

This PR was not supposed to be merged, there were still some errors in the tests. I will revert it.

zanderso added a commit that referenced this pull request Sep 26, 2022
@a-siva a-siva deleted the null-safety branch September 28, 2022 20:27
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants