Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add matrix makerow and makecolumn. #36312

Merged
auto-submit merged 2 commits into from
Sep 22, 2022
Merged

[Impeller] Add matrix makerow and makecolumn. #36312

auto-submit merged 2 commits into from
Sep 22, 2022

Conversation

@guoguo338
Copy link
Contributor

@guoguo338 guoguo338 commented Sep 21, 2022 •
edited
Loading

This PR is for issue: flutter/flutter#111165

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guoguo338
Add matrix makerow and makecolumn.
cd380ae 
Signed-off-by: xieguo <xieguo@bytedance.com>
@ColdPaleLight ColdPaleLight requested review from bdero and chinmaygarde and removed request for bdero September 21, 2022 07:08
@ColdPaleLight ColdPaleLight changed the title Add matrix makerow and makecolumn. [Impeller] Add matrix makerow and makecolumn. Sep 21, 2022
@guoguo338
Adjust lines.
19ca3fc 
Signed-off-by: xieguo <xieguo@bytedance.com>
ColdPaleLight
ColdPaleLight approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@ColdPaleLight ColdPaleLight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2022
@auto-submit auto-submit bot merged commit fb0de49 into flutter:main Sep 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
fb0de49 [Impeller] Add matrix makerow and makecolumn. (flutter/engine…
03b5864 
…#36312)
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@guoguo338
[Impeller] Add matrix makerow and makecolumn. (flutter#36312)
2f22a69
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdero bdero Awaiting requested review from bdero

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@ColdPaleLight ColdPaleLight ColdPaleLight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@guoguo338 guoguo338

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guoguo338 @chinmaygarde @ColdPaleLight