This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] Clone VideoFrame when cloning CkImage #36299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Sep 21, 2022
| final VideoFrame videoFrameClone = videoFrame!.clone(); | ||
| return CkImage.cloneOf(box, videoFrame: videoFrameClone); | ||
| } | ||
| return CkImage.cloneOf(box); |
Contributor
There was a problem hiding this comment.
I think the above 5 lines can be compressed into one:
return CkImage.cloneOf(box, videoFrame: videoFrame?.clone());(bonus: also remove a null assertion)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clones the
VideoFramewhen cloning aCkImage. This allows us to use theVideoFramein the cloned image for encoding.Fixes flutter/flutter#102683
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.