This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix uniform buffer bindings to point to the right var #36293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e4d473 to
7cf192b
Compare
| # OCMock is for testing only so there is no google clone | ||
| 'ocmock_git': 'https://github.com/erikdoe/ocmock.git', | ||
| 'skia_revision': '14ebc89de8b8ec7d350b3743ad4c14a969e4f596', | ||
| 'skia_revision': 'e89e47d02a2338c72aa09a153770cba70571ad99', |
Contributor
There was a problem hiding this comment.
Did you mean to stage this?
7cf192b to
755cba6
Compare
| } | ||
|
|
||
| #ifndef IMPELLER_ENABLE_VULKAN | ||
| GTEST_SKIP(); |
Contributor
There was a problem hiding this comment.
This should work on all backends. Specifying the binding and set should not be a Vulkan only thing.
chinmaygarde
approved these changes
Sep 20, 2022
755cba6 to
2e6f750
Compare
Contributor
|
auto label is removed for flutter/engine, pr: 36293, due to - The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
2e6f750 to
675898d
Compare
* also retain uniform slot info * rename existing binding to ext_res_0
675898d to
49360c4
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 21, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.