This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable Mac iOS Engine in recipes tests #36256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Mac iOS Engine target to flutter/recipes CQ. This will ensure that changes to flutter/recipes pass on the Mac iOS Engine target before landing.
The recipes code has a temporary workaround to resolve a P0 related to Mac iOS Engine. A proper workaround has been readied, but the Mac iOS Engine target fails to build and test when run as an individual tryjob in a CL. This is because running it individually does not pass it the necessary config. This change will make the Mac iOS Engine target run for every flutter/recipes CL and with proper config, which will let us validate changes that affect it.
flutter/flutter#111226
flutter/flutter#111193
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.