This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] fix screen orientation lock bug #36253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Sep 19, 2022
| /// | ||
| /// See w3c screen api: https://www.w3.org/TR/screen-orientation/ | ||
| Future<bool> setPreferredOrientation(List<dynamic> orientations) { | ||
| final DomScreen screen = domWindow.screen!; |
lib/web_ui/lib/src/engine/dom.dart
Outdated
Comment on lines
1307
to
1309
| if (jsResult is Future) { | ||
| return jsResult; | ||
| } |
Contributor
There was a problem hiding this comment.
This check seems fine to me, but I don't know if this is the right place for it. Maybe js_util.promiseToFuture should do this check internally? I'm not sure.
Or like you said, maybe allowInterop should convert futures to promises.
Contributor
Author
There was a problem hiding this comment.
Actually, I changed the test to use the Promise API directly, so there's no futures to convert. Looks much better now. The point about allowInterop limitation still stands though, although less relevant to this PR now.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the mapping of Flutter screen orientation values to
window.screen.orientation.lockequivalents. Our previous tests were broken too. They weren't testing what they thought they were testing (e.g.js_util.setProperty(screen, 'orientation', null)is a noop). This PR fixes tests as well.Bonus: remove the no longer necessary
unsafeIsNull. In the past we used it withdart:html, wheredart:htmlused incorrect nullability annotations, we needed a way to null check non-nullable types. That's gone, and whatever remained works perfectly fine with just== nulland!= null.Fixes flutter/flutter#88269