This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix HTML renderer does not render non zeroed width borders #36249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, the HTML renderer does not render properly borders when
width > 0.(FYI, rendering zeroed width borders was fixed in #34812).
When
width > 0, the border is rendered by callingRecordingCanvas.drawRect. TheRectis computed byPathRef._detectRectwhich might return aRectwith negative width and/or height, this leads to wrong computations when clipping (and the border being not visible).This PR fixed
PathRef._detectRectto return aRectwith positive width and height.Related Issue
Fixes flutter/flutter#111750
Tests
Adds 2 tests.