Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jiahaog
Copy link
Member

@jiahaog jiahaog commented Sep 19, 2022

The signature of systemChromeChanged is

public void systemChromeChanged(boolean overlaysAreVisible);

But the wrong value of overlaysAreVisible is propagated, resulting in the incorrect value received by setSystemUIChangeCallback.

List which issues are fixed by this PR. You must list at least one issue.

Fix flutter/flutter#111618

setSystemUIChangeCallback isn't used internally, but I also patched this change and ran an internal presubmit to double check. Since there are no failing tests, this isn't a breaking change.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jiahaog jiahaog force-pushed the systemchrome-inverted branch from fe716f9 to 65c1f41 Compare September 20, 2022 00:20
@jiahaog jiahaog marked this pull request as ready for review September 20, 2022 01:54
@jiahaog jiahaog requested a review from Piinks September 20, 2022 01:54
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing this - I am still baffled such a clear mix up landed. 🙃

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit auto-submit bot merged commit b89200a into flutter:main Sep 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2022
@jiahaog jiahaog deleted the systemchrome-inverted branch September 21, 2022 00:03
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The callback set by setSystemUIChangeCallback seems to be called with inverted values on Android

2 participants