This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix inverted setSystemUIChangeCallback #36248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of
systemChromeChangedisBut the wrong value of
overlaysAreVisibleis propagated, resulting in the incorrect value received bysetSystemUIChangeCallback.List which issues are fixed by this PR. You must list at least one issue.
Fix flutter/flutter#111618
setSystemUIChangeCallbackisn't used internally, but I also patched this change and ran an internal presubmit to double check. Since there are no failing tests, this isn't a breaking change.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.