Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Clear platform view caches at begin frame in unittest #36214

Merged
auto-submit merged 1 commit into from
Sep 19, 2022
Merged

Clear platform view caches at begin frame in unittest #36214

auto-submit merged 1 commit into from
Sep 19, 2022

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Sep 16, 2022 •
edited
Loading

Clears the visited_platform_views_, mutators_stacks_, current_composition_params_ at beginFrame in ShellTestExternalViewEmbedder

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz marked this pull request as ready for review September 16, 2022 19:03
jason-simmons
jason-simmons reviewed Sep 16, 2022
View reviewed changes
shell/common/shell_test_external_view_embedder.cc
double device_pixel_ratio,
fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger) {}
fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger) {
visited_platform_views_.clear();
Copy link
Member

@jason-simmons jason-simmons Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should current_composition_params_ and mutators_stacks_ also be cleared?

Copy link
Contributor Author

@cyanglaz cyanglaz Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, fixed.

@cyanglaz cyanglaz changed the title Clear visited platform views at begin frame in unittest Clear platform view caches at begin frame in unittest Sep 16, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 16, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman
Copy link
Member

jmagman commented Sep 16, 2022

It looks like this pull request may not have tests.

This regex could be updated to match:
https://github.com/flutter/cocoon/blob/2dabcdde606191a82fb9f94a22d7ed13d637f10b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart#L36

jmagman
jmagman reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this causing test issues? Or did you just notice it was missing?

@Hixie
Copy link
Contributor

Hixie commented Sep 16, 2022

test-exempt: is a test

I recommend updating the bot as suggested by @jmagman to avoid needing to wait on me in the future

@jason-simmons
Copy link
Member

jason-simmons commented Sep 16, 2022

There have been recent flakes in ShellTest.PushBackdropFilterToVisitedPlatformViews (see #36212)

This was found while looking into that test.

jmagman
jmagman approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 17, 2022

auto label is removed for flutter/engine, pr: 36214, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman
Copy link
Member

jmagman commented Sep 17, 2022

Not sure why the framework input_decorator_test smoke test is failing. This is branched off 46037aa which isn't that old. Maybe you still need a rebase?

@cyanglaz cyanglaz force-pushed the visited_platform_view_test_fix branch from f84b4b8 to 072ec26 Compare September 19, 2022 17:36
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@auto-submit auto-submit bot merged commit c45ce0e into flutter:main Sep 19, 2022
@cyanglaz cyanglaz deleted the visited_platform_view_test_fix branch September 19, 2022 18:35
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2022
@engine-flutter-autoroll
c45ce0e Clear platform view caches at begin frame in unittest (flutte…
d138cab 
…r/engine#36214)
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Clear platform view caches at begin frame in unittest (flutter#36214)
a8fe008
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jmagman jmagman jmagman approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyanglaz @jmagman @Hixie @jason-simmons