This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove old unused golden diffing #36132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Sep 14, 2022
| other: screenshot, | ||
| pixelComparison: pixelComparison, | ||
| ); | ||
| // TODO(mdebbar): Use the Gold tool to locally diff the golden. |
Member
There was a problem hiding this comment.
Is this method returning anything other than 'OK' now?
Member
There was a problem hiding this comment.
Ah, this is only for local diffs, ok.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to do our own image diffing in the past, but that went away when we adopted Skia Gold. Some pieces of the old diffing are still present in the code. This PR attempts to clean it up.
In the future, when we decide to support local golden diffing, we can use the Gold tool to perform local diffing using the
matchcommand.