This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move subprocess.run to popen. #36104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out subprocess.run is available only after 3.5 and it is failing in our bots. Bug: flutter/flutter#81855
Contributor
|
Is this necessary if we are still waiting for Popen to finish? If I understand correctly the benefit of Popen would be that we could do other work asynchronously instead vs waiting for run to finish. |
Contributor
Author
This command used to use check_call but I updated it to subprocess.run to be able to print stdout and stderr but it turns out that the python version used in the bots is <3.5. In this case we are using popen only to be able to capture stderr and stdout in a way that is compatible with different versions of python. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2022
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out subprocess.run is available only after 3.5 and it is failing in our bots.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.