Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@akbiggs
Copy link
Contributor

@akbiggs akbiggs commented Sep 9, 2022

This runner is no longer used anywhere, it has been fully replaced with the CF v2 runner.

  • Rename DartComponentControllerV2 -> DartComponentController, delete the v1 DartComponentController. This led to a confusing diff.

The Flutter CF v1 runner is still in-use.

@richkadel FYI

Tested: Ran Workstation, ran the Dart CF v2 RealmBuilder test.

@akbiggs akbiggs force-pushed the delete_v1_dart_runner branch 2 times, most recently from 7b37b7a to 530d710 Compare September 9, 2022 05:31
@richkadel
Copy link

This is awesome. Looks good to me, except the Linux License builder shows some lines that need to be removed in flutter/ci/licenses_golden/licenses_flutter

Thanks for doing this Alex!

@akbiggs akbiggs force-pushed the delete_v1_dart_runner branch from 530d710 to 3b7f9f0 Compare September 12, 2022 21:46
@akbiggs akbiggs added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@akbiggs akbiggs force-pushed the delete_v1_dart_runner branch from 3b7f9f0 to b330a1b Compare September 13, 2022 15:24
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 13, 2022

auto label is removed for flutter/engine, pr: 36029, due to - This commit has no checks. Please check that ci.yaml validation has started and there are multiple checks. If not, try uploading an empty commit.

@akbiggs akbiggs added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 13, 2022

auto label is removed for flutter/engine, pr: 36029, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

This runner is no longer used anywhere, it has been fully
replaced with the CF v2 runner.

The Flutter CF v1 runner is still in-use.
@akbiggs akbiggs force-pushed the delete_v1_dart_runner branch from b330a1b to db4e9d5 Compare September 13, 2022 21:00
@akbiggs akbiggs added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit auto-submit bot merged commit 4342ce4 into flutter:main Sep 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2022
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-fuchsia

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants