This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the frame size to cull #35973
Merged
Use the frame size to cull #35973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
commented
Sep 7, 2022
| dl_recorder_ = sk_make_sp<DisplayListCanvasRecorder>(kGiantRect); | ||
| FML_DCHECK(!frame_size.isEmpty()); | ||
| dl_recorder_ = | ||
| sk_make_sp<DisplayListCanvasRecorder>(SkRect::Make(frame_size)); |
Contributor
Author
There was a problem hiding this comment.
This right here is what makes the magic for impeller. This code path is used for impeller, and this will cause the SkCanvas implementation underlying the recorder here to quickReject drawing ops that fall outside of it, which will gate off a whole lot of allocations of impeller-specific geometry (e.g. not creating impeller::Path objects for SkPaths that fall entirely outside these bounds).
akbiggs
reviewed
Sep 7, 2022
bdero
approved these changes
Sep 7, 2022
Contributor
Author
|
I'm going to wait until I can rebase this on #35978 just to try to be extra sure I'm not using these sizes after they get moved :) |
Contributor
Author
|
Actually, that patch will catch issues with this on post submit anyway. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
Member
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes through the frame size parameter from
Surface::AcquireFrametoSurfaceFrame. This primarily helps impeller, which no longer needs to usekGiantRectand will be able to more aggressively cull away graphical operations/geometry that fall outside of the frame's bounds.This is part of a fix for flutter/flutter#110442. We should still do the work @bdero is proposing in #35966, but this will cover cases where clips in the DL/layer tree don't save us.
I still think we could be doing this kind of culling higher up in the stack in the framework (see flutter/flutter#111065).