Try to deflake service isolate startup #35950
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bkonyi
left a comment
There was a problem hiding this comment.
Looks reasonable to me, may as well give it a shot :)
|
test-exempt: fixing a test |
|
Did this change actually deflake the service isolate startup issue ? |
|
No, this did not seem to have any impact on the flake. |
Speculative fix for flutter/flutter#106753
Re-orders the call to making the isolate runnable to the end, after we set the private fields.
Tested this locally and it seems to work fine, but I had not reproduced the flake locally.