Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unnecessary include of private Skia header #35949

Merged
jason-simmons merged 1 commit into from
Sep 6, 2022
Merged

Remove unnecessary include of private Skia header #35949

jason-simmons merged 1 commit into from
Sep 6, 2022

Conversation

@kjlubick
Copy link
Contributor

@kjlubick kjlubick commented Sep 6, 2022

src/codec/SkCodecImageGenerator.h is a private Skia header and should not be directly included. It appears this include is innocuous, as the private types are not (no longer?) used. However, this include may cause an issue when flutter_engine is rolled into G3.

Pre-launch Checklist

  • [ x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [ x ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [ x ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • [ x ] I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 6, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 6, 2022

auto label is removed for flutter/engine, pr: 35949, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 6, 2022

auto label is removed for flutter/engine, pr: 35949, due to Validations Fail.

@jason-simmons jason-simmons merged commit 2b75dd8 into flutter:main Sep 6, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
2b75dd8 Remove unnecessary include of private Skia header (flutter/en…
e850317 
…gine#35949)
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@kjlubick
Remove unnecessary include of private Skia header (flutter#35949)
b7b759a
@kjlubick kjlubick deleted the remove-image-gen branch November 1, 2022 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kjlubick @jason-simmons