Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@akbiggs
Copy link
Contributor

@akbiggs akbiggs commented Sep 6, 2022

Tested: run_integration_tests.sh embedder --no-lto

Tested: `run_integration_tests.sh embedder`
Copy link
Contributor

@lin-erik lin-erik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, we can probably extend the run_integration_test script for use with other directories (like the dart_runner integration tests, etc)?

@akbiggs
Copy link
Contributor Author

akbiggs commented Sep 6, 2022

Just a thought, we can probably extend the run_integration_test script for use with other directories (like the dart_runner integration tests, etc)?

Yes I think it should work fine for that usecase. Some stuff will need to be changed:

  • instead of building from fuchsia/flutter it should build from fuchsia/dart
  • the warning about headless environments should be disabled (maybe even removed outright, I haven't seen any issues running the tests from a headless environment yet)
  • The script will need to copy over the oot_dart_jit_runner instead of the oot_flutter_jit_runner.

I think flipping all of that stuff can be based on whether the test name is a Dart integration test vs. Flutter integration test.

@akbiggs akbiggs merged commit 548f978 into flutter:main Sep 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 6, 2022
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Tested: `run_integration_tests.sh embedder`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants